Fix travis stages #217
Merged
Fix travis stages #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it were, "deploy" would run before "test" because it was left out of the stages section. Instead of running "test" and "deploy" stages on tags, to run just "deploy"; we already require that all tests have passed before someone pushes a tag for deployment anyway, no sense running the tests again.
blueyed
approved these changes
Feb 22, 2019
blueyed
reviewed
Feb 22, 2019
| @@ -19,8 +19,10 @@ env: | |||
| #- DEPS="pytest~=3.1.0" | |||
|
|
|||
| stages: | |||
| - name: test | |||
| if: tag IS NOT present | |||
There was a problem hiding this comment.
Never push a tag without having it tested first.. ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it were, "deploy" would run before "test" because it was left out of the
stages section.
Instead of running "test" and "deploy" stages on tags, to run just
"deploy"; we already require that all tests have passed before someone pushes
a tag for deployment anyway, no sense running the tests again.