Avoid using PyCollector - inherit from Module instead
#40
+21
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyCollector is technically private in pytest and might change/break. The DescribeBlocks act like modules, so instead treat them as ones directly.
bluetech
commented
Nov 13, 2021
| @@ -78,10 +89,6 @@ def collect(self): | |||
| def _getobj(self): | |||
| return self._importtestmodule() | |||
|
|
|||
| def _makeid(self): | |||
There was a problem hiding this comment.
By passing nodeid directly, we don't need this. Also, newer versions of pytest no longer use _makeid.
There was a problem hiding this comment.
Right, this was removed here in pytest 3.5, and we now require pytest 4.6.
jacebrowning
approved these changes
Nov 13, 2021
There was a problem hiding this comment.
Thanks! This looks reasonable to me.
@Cito, we might want to make a beta release with this change.
|
Thanks for the heads-up and PR, @bluetech. @jacebrowning Will check this with a larger real-world project, and I think will then just publish a 2.0.1 patch release. There is no pytest 7 alpha or beta yet, and our test matrix does not cover it, so we will need to check this again when pytest 7 comes out. |
|
Version 2.01 is out now. |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyCollectoris technically private in pytest and might change/break. TheDescribeBlocks act like modules, so instead treat them as ones directly.Hi, over in pytest we are considering whether to expose
PyCollectoror treat it as an internal implementation detail (ref: pytest-dev/pytest#9264). My opinion is that it should be private. Looking at plugins which might be affected by this, I found one case - pytest-describe. I believe that pytest-describe can avoidPyCollectorwith the change proposed here.BTW, this plugin is really ingenious - treating functions as an extra Python namespacing mechanism by treating them as modules, that's a cool concept :)