Test case using transaction aren't isolated on the non default databases

[xordoquy]

This is a regression I have with pytest-django 2.9 - doesn't happen with 2.8. Django is 1.7.1, py.test 2.8.2 and Python 3.4.
Some of my tests are using transactions and aren't run in isolation to each other any longer. They are part of a unittest.TestCase.
Performing a git bisect, the commit 0ec741b seems to introduce the regression.

This is probably due to the fact that it now only applies rollbacks to Django TestCase and no more with unittest's ones.

[blueyed]

So it is about transactional_db, right?

[xordoquy]

indeed, sorry, should have mentioned it.

[blueyed]

Thanks for notifying us, and bisecting it.

Can you come up with a test case, based on the existing ones?
I would have thought that this is tested already, but we're not using transactions in there then probably.

[xordoquy]

ah, sorry, I'm confusing terms.
I don't use the transactional_db feature. The file is marked as pytest.mark.django_db(transaction=True)

[xordoquy]

Will try to get a test case for it though won't be able to work on this before next week.

[blueyed]

I don't use the transactional_db feature. The file is marked as pytest.mark.django_db(transaction=True)

That is quite the same though, just another way to mark/express it.

[xordoquy]

OK, I've been trying to reproduce the issue but failed.
I've probably missed a point in my initial analysis. The real project uses a multi database configuration and the secondary databases aren't rolled back. It's not the use of unittest.TestCase that causes this isolation issue.

Will try to get a failing test case but it'll be slightly more complex.

Edit: I changed the title to reflect this.

[blueyed]

@xordoquy
Thanks for reporting back.
It would be sweet nonetheless to have some extra test to make sure it works as expected, in case it's not tested for already. Please let us know about your findings and keep that (contributing extra tests) in mind.

[xordoquy]

@blueyed that's on my todo list. Could find some time to work on this today, I was just reporting back.

[bluetech]

Closing this issue as it's probably no longer relevant.