Getting error "setUpClass should be a classmethod"

[kleptog]

Recently some magic was added that tries wrap the setUpClass methods for some reason. Not sure why. In any case, it breaks our testsuite. I've attached a test file to reproduce.

The basic issue is that the the setUpClass raises a skip exception sometimes to cause the methods defined in that class to be skipped. This causes the wrapping code to skip restoring the classmethod, leading to errors later on.

The error is in this code:

pytest-django/pytest_django/plugin.py

Lines 417 to 419 in a67ab3b

	_restore_class_methods(cls)
	cls.setUpClass()
	_disable_class_methods(cls)

If the setUpClass() throws an exception (in this case Skip), the restore is skipped and chaos ensues.

This is a test file that reproduces it:

import pytest
from django.test import SimpleTestCase


class foo(SimpleTestCase):
    @classmethod
    def setUpClass(cls):
        if cls is foo:
            raise pytest.skip("Skip base class")
        super(foo, cls).setUpClass()

    def test_shared_foo(self):
        pass


class bar(foo):
    def test_bar1(self):
        pass


class bar2(foo):
    def test_bar21(self):
        pass

[blueyed]

Thanks for the report.

I guess it should be wrapped with a try: … finally maybe to call _disable_class_methods always?

The commit is quite old, but likely was only released recently then? (96f5fb1)

It's good to have a test case.
Can you please create a PR from it?

[kleptog]

Actually, after sleeping on it I think just adding a try/except isn't enough: at the point the exception is thrown the method has been set back, so this can't be the issue.

More digging revealed the actual problem: the classmethod test was incorrect. The testcase can be made even simpler: replacing the setUpClass with just pass still break.

Making a pull request now.

[kleptog]

Ok, buildbot passed my patch. Actually two bugs in the end, but now it all works :)