Skip to content

Remove Python 3.8 & Django 5.0 #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 26, 2025
Merged

Remove Python 3.8 & Django 5.0 #1202

merged 9 commits into from
May 26, 2025

Conversation

kingbuzzman
Copy link
Contributor

@kingbuzzman kingbuzzman commented May 26, 2025

Removes:

  • Python 3.8
  • Django 5.0
  • Updates imports because of ruff linter (the minimum python change)

@kingbuzzman kingbuzzman changed the title Remove python 3.8 Remove Python 3.8 & Django 5.1 May 26, 2025
@kingbuzzman kingbuzzman changed the title Remove Python 3.8 & Django 5.1 Remove Python 3.8 & Django 5.0 May 26, 2025
@kingbuzzman kingbuzzman marked this pull request as ready for review May 26, 2025 15:35
@kingbuzzman kingbuzzman requested review from Copilot, adamchainz and bluetech and removed request for adamchainz May 26, 2025 15:35
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes support for Python 3.8 and Django 5.0 and updates related configurations and type imports to align with a minimum Python version of 3.9. The key changes include updates to pytest test parameterization syntax, migration of type imports from typing to collections.abc, and adjustments to the testing matrix and classifiers in the project configuration files.

Reviewed Changes

Copilot reviewed 10 out of 13 changed files in this pull request and generated no comments.

File Description
tests/test_runner.py Updated pytest.mark.parametrize usage to use a tuple instead of a comma-delimited string.
tests/test_fixtures.py, test_database.py, pytest_django_test/db_helpers.py, pytest_django/runner.py, pytest_django/plugin.py, pytest_django/fixtures.py, pytest_django/asserts.py Updated type import patterns to use collections.abc for forward compatibility.
pyproject.toml Adjusted the minimum Python requirement (>=3.9) and updated Django classifiers.
.github/workflows/main.yml Removed Python 3.8 test jobs to reflect the new minimum Python version.
Files not reviewed (3)
  • README.rst: Language not supported
  • docs/contributing.rst: Language not supported
  • tox.ini: Language not supported
Comments suppressed due to low confidence (2)

tests/test_runner.py:9

  • [nitpick] Using tuple notation for pytest.mark.parametrize is valid, but please ensure that the team agrees on this style for consistency across the test suite.
('kwargs', 'expected')

.github/workflows/main.yml:131

  • The removal of Python 3.8 test jobs aligns with the updated minimum Python version; ensure that any related documentation and usage notes are updated accordingly.
-        - name: py38-dj42-sqlite-xdist-coverage

Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, otherwise looks good to me, thanks @kingbuzzman! Feel free to merge after the fix.

python: '3.8'
allow_failure: false

# Explicitly test min pytest.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep one job testing the pytestmin. Best to just bump this one to py39.

@kingbuzzman kingbuzzman merged commit 7c99f33 into main May 26, 2025
20 checks passed
@kingbuzzman kingbuzzman deleted the dev/remote-py38 branch May 26, 2025 21:35
@kingbuzzman
Copy link
Contributor Author

@bluetech can we release a little minor for this? I can see this being a little annoying for folks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants