Django 2.0 ImportError on django.core.urlresolvers #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
approved these changes
Sep 23, 2017
blueyed
reviewed
Sep 23, 2017
pytest_django/plugin.py
Outdated
| try: | ||
| from django.core.urlresolvers import clear_url_caches, set_urlconf | ||
| except ImportError: | ||
| from django.urls import clear_url_caches, set_urlconf |
There was a problem hiding this comment.
Shouldn't it prefer the new version?
|
Also a comment would make sense here. |
jpic
force-pushed
the
patch-1
branch
2 times, most recently
from
20cfeb4 to
3c6def2
Compare
|
Thanks @jpic! |
ashwoods
pushed a commit
to ashwoods/pytest-django
that referenced
this pull request
Oct 11, 2017
dulacp
pushed a commit
to dulacp/pytest-django
that referenced
this pull request
Dec 2, 2017
timb07
pushed a commit
to timb07/pytest-django
that referenced
this pull request
May 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.