Use pathlib2

[adamchainz]

The dependency on pathlib was added in #631. A backport is needed for Python <3.4.

The pathlib package on PyPI is maintenance-only and comes with a message about using pathlib2 for an up-to-date version. Also pytest itself uses pathlib2 so currently I'm getting both packages installed when one would do.

This change in setup.py seems to be all that's needed to switch.

[blueyed]

Thanks, but from CI failures it looks like it needs something else for Python 2?

[adamchainz]

Woops, turns out they don't have the same library name.

[codecov-io]

Codecov Report

Merging #636 into master will increase coverage by 6.91%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #636      +/-   ##
==========================================
+ Coverage   85.76%   92.68%   +6.91%     
==========================================
  Files          33       33              
  Lines        1799     1805       +6     
  Branches      154      154              
==========================================
+ Hits         1543     1673     +130     
+ Misses        204       94     -110     
+ Partials       52       38      -14

Flag	Coverage Δ
#dj110	84.76% <50%> (?)
#dj111	87.2% <100%> (+6.04%)	⬆️
#dj18	85.76% <100%> (?)
#dj19	84.54% <50%> (?)
#dj20	85.04% <50%> (-0.18%)	⬇️
#dj21	80.99% <50%> (?)
#mysql_innodb	85.26% <100%> (?)
#mysql_myisam	85.09% <100%> (?)
#postgres	88.47% <100%> (+3.26%)	⬆️
#py27	90.19% <100%> (?)
#py34	84.54% <50%> (?)
#py35	84.76% <50%> (?)
#py36	85.59% <50%> (-0.18%)	⬇️
#py37	80.99% <50%> (?)
#sqlite	86.75% <50%> (+5.6%)	⬆️
#sqlite_file	84.54% <50%> (?)

Impacted Files	Coverage Δ
pytest_django/plugin.py	86.47% <100%> (+4.09%)	⬆️
tests/conftest.py	100% <100%> (+5.66%)	⬆️
pytest_django/fixtures.py	97.22% <0%> (+1.11%)	⬆️
tests/test_fixtures.py	99.59% <0%> (+1.6%)	⬆️
tests/test_environment.py	100% <0%> (+2.17%)	⬆️
tests/test_db_setup.py	100% <0%> (+4.39%)	⬆️
tests/test_urls.py	100% <0%> (+8.33%)	⬆️
tests/test_database.py	99.16% <0%> (+11.66%)	⬆️
... and 8 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5619f16...e9e0d57. Read the comment docs.

Updated

[graingert]

looks like pytest are going to start exposing pathlib: https://twitter.com/ossronny/status/1043438562535006209?s=19

[blueyed]

@graingert
Why is that relevant here?

[graingert]

This code should change to from pytest import pathlib and will need the pathlib dep removed from setup.py

[blueyed]

Ah, I see. Thanks.
No requirement though, but good to have - care to creatte a new issue to track this?

[adamchainz]

Made #660