Use request.config instead of pytest.config

[blueyed]

Will be deprecated in pytest 4.1.
Ref: pytest-dev/pytest@b88c3f8f828

[codecov-io]

Codecov Report

Merging #677 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #677   +/-   ##
=======================================
  Coverage   94.43%   94.43%           
=======================================
  Files          33       33           
  Lines        1852     1852           
  Branches      158      158           
=======================================
  Hits         1749     1749           
  Misses         78       78           
  Partials       25       25

Flag	Coverage Δ
#dj110	86.33% <100%> (ø)	⬆️
#dj111	88.71% <100%> (ø)	⬆️
#dj18	87.31% <100%> (ø)	⬆️
#dj19	86.12% <100%> (ø)	⬆️
#dj20	86.6% <100%> (ø)	⬆️
#dj21	82.66% <100%> (ø)	⬆️
#djmaster	82.66% <100%> (ø)	⬆️
#mysql_innodb	86.82% <100%> (ø)	⬆️
#mysql_myisam	86.66% <100%> (ø)	⬆️
#postgres	89.95% <100%> (ø)	⬆️
#py27	91.63% <100%> (ø)	⬆️
#py34	86.12% <100%> (ø)	⬆️
#py35	86.33% <100%> (ø)	⬆️
#py36	87.52% <100%> (ø)	⬆️
#py37	82.66% <100%> (ø)	⬆️
#sqlite	88.66% <100%> (ø)	⬆️
#sqlite_file	86.12% <100%> (ø)	⬆️

Impacted Files	Coverage Δ
pytest_django/fixtures.py	97.31% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3dc56d...c997bef. Read the comment docs.

[ransford]

Does this merit a pytest-django version bump?

I just added --disable-pytest-warnings to a project because the combination of pytest 4.1.0 + pytest-django 3.4.4 was making my tests fail like this:

_____________________ ERROR at setup of test_my_thing _____________________
E   _pytest.warning_types.PytestDeprecationWarning: the `pytest.config` global is deprecated.  Please use `request.config` or `pytest_configure` (if you're a pytest plugin) instead.

A traceback led to two occurrences of pytest.config in pytest_django/fixtures.py.

[PiDelport]

Does this merit a pytest-django version bump?

Yes please! 🙏

[blueyed]

PytestDeprecationWarning

Why is this an error?
Are you using --strict or something like that?
It should only show up in "warnings summary" normally.

While a new release makes sense I'd like to understand what happens here.

[nicoddemus]

Probably they have setup the warnings filter to error.

[blueyed]

@ransford @pjdelport
?

[ransford]

Yes, sorry I forgot to mention that. I had error in the filterwarnings stanza of pytest.ini (on purpose).

[blueyed]

Thanks for the feedback, tagged a new release. Will take a short while until it appears on PyPI.
https://travis-ci.org/pytest-dev/pytest-django/builds/476522277

[ransford]

Thanks @blueyed (for the new release and your work on this project)!