Skip to content

Revisit unittest handling #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2019
Merged

Revisit unittest handling #740

merged 3 commits into from
May 30, 2019

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented May 30, 2019

While looking into #710.

@codecov-io
Copy link

codecov-io commented May 30, 2019

Codecov Report

Merging #740 into master will decrease coverage by 0.29%.
The diff coverage is 89.47%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #740     +/-   ##
========================================
- Coverage    97.9%   97.6%   -0.3%     
========================================
  Files          32      32             
  Lines        1863    1881     +18     
  Branches      147     147             
========================================
+ Hits         1824    1836     +12     
- Misses         26      32      +6     
  Partials       13      13
Impacted Files Coverage Δ
pytest_django/plugin.py 94.01% <89.47%> (-0.02%) ⬇️
tests/test_db_setup.py 95.23% <0%> (-4.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed958e6...63abadf. Read the comment docs.

self._pre_setup()
super(cls, self).debug()
if not skipped:
self._post_teardown()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only not skipped is covered here. But also previously.

@blueyed blueyed merged commit ec9741d into pytest-dev:master May 30, 2019
@blueyed blueyed deleted the unittest branch May 30, 2019 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants