Skip to content

WIP: drop support for pytest < 4.2 #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Jun 4, 2019

No description provided.

@boxed
Copy link
Contributor

boxed commented Mar 18, 2020

This is actually a pretty huge deal! The import of pkg_resources is pretty expensive. It amounts to something like 20% of the overhead of my test runner hammett when using this plugin!

@blueyed
Copy link
Contributor Author

blueyed commented Mar 18, 2020

@boxed
Yeah, importing/using pkg_resources just for this is really bad after all. pytest should probably have a version_info tuple.

I'll look into removing this separately already.

blueyed added a commit to blueyed/pytest-django that referenced this pull request Mar 18, 2020
blueyed added a commit that referenced this pull request Mar 18, 2020
Speeds up `pytest --version` from 249ms to 204ms.

Ref: #744 (comment)
@blueyed
Copy link
Contributor Author

blueyed commented Mar 18, 2020

@boxed done, thanks for pointing it out!

@blueyed
Copy link
Contributor Author

blueyed commented Mar 18, 2020

@boxed as for performance in pytest itself see pytest-dev/pytest#4376.
I might take this into blueyed/pytest soon, you might want to try adding your "test case" / scenario there already.

beyondgeeks pushed a commit to beyondgeeks/django-pytest that referenced this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants