live_server: fix in-memory DB detection, dj 2.2 compat #793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 5, 2020
blueyed
added a commit
to blueyed/pytest-django
that referenced
this pull request
Jan 7, 2020
blueyed
added a commit
to blueyed/pytest-django
that referenced
this pull request
Jan 13, 2020
Closed
blueyed
added a commit
to blueyed/pytest-django
that referenced
this pull request
Jan 21, 2020
blueyed
added a commit
to blueyed/pytest-django
that referenced
this pull request
Jan 22, 2020
blueyed
added a commit
to blueyed/pytest-django
that referenced
this pull request
Mar 31, 2020
blueyed
force-pushed
the
live_server-inc_thread_sharing
branch
from
ec6f271 to
b29b1b5
Compare
|
Are there any plans to merge this change ? We think this can fix our pytest errors. Thank You. |
|
I'd love to pick it up, @blueyed could you provide some background on this PR, i.e with the changes that remove the thread logic, how will this still work? |
|
I hit this exact problem today! Would love it if this was merged and released! |
|
Fixed in #973 (didn't see this one before...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #783.
TODO:
dec_thread_sharing()? (also for dj < 2.2 then likely)