Fix LiveServer for in-memory SQLite database on Django >= 3.
#947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`allow_thread_sharing` is no longer writeable since Django 3.0a1.
bluetech
requested changes
Nov 29, 2021
pytest_django/live_server_helper.py
Outdated
| @@ -24,7 +24,10 @@ def __init__(self, addr: str) -> None: | |||
| and conn.settings_dict["NAME"] == ":memory:" | |||
| ): | |||
| # Explicitly enable thread-shareability for this connection | |||
| conn.allow_thread_sharing = True | |||
| try: | |||
| conn.inc_thread_sharing() | |||
There was a problem hiding this comment.
We also need to do the corresponding dec_thread_sharing in stop(). Django's LiveServerTestCase does it here: https://github.com/django/django/blob/3ff7f6cf07a722635d690785c31ac89484134bee/django/test/testcases.py#L1578
This is a pre-existing issue -- the previous code neglected set allow_thread_sharing back as well, but this is a good opportunity to fix it.
There was a problem hiding this comment.
I am not sure id my copy-paste solution is correct, feel free to change my code.
|
I am not planning to fix the coverage problems. This is too much for a drive-by contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow_thread_sharingis no longer writeable since Django 3.0a1.