-
Notifications
You must be signed in to change notification settings - Fork 89
Remove request_ctx
Fixture
#168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Is there anything stopping this from being merged now and a release being made? |
I'm interested in a new release with that too :) |
I'm improving/fixing CI in #169, after that gets merged I think we can merge this one as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is that the internal api used there is intentionally made gone
Is there another way we can safely enter the request context?
Nm, I wasn't in the full picture |
Thanks a lot @threeal and sorry for the delay. I will prepare a new release shortly. |
|
This pull request removed the
request_ctx
fixture since it has been marked deprecated for a long time and currently it is not supported on the Flask v3.0.0.For a side note, inlining the import won't work since it could still break the test if using Flask v3.0.0.
pytest-flask
import of_request_ctx_stack
#167.Checklist:
docs/CHANGELOG.rst
, summarizing the change and linking to the issue.pre-commit
hooks and fix any issues.pytest
and make sure no tests failed.