Skip to content

Conversation

BeyondEvil
Copy link
Contributor

Seems like ´optionalhook´ was never used.

´hookwrapper´ generated PytestUnknownMarkWarning

and I couldn't find anything regarding it explicitly in the changelog of pytest.

Replaced it with @pytest.hookimpl(hookwrapper=True) which did not generate any warnings.

Care to shed some light on the above @nicoddemus @RonnyPfannschmidt ?

@nicoddemus
Copy link
Member

@BeyondEvil not sure, doesn't ring a bell at the moment, but the changes LGTM.

@BeyondEvil BeyondEvil merged commit 6abbbff into pytest-dev:master Aug 5, 2019
@BeyondEvil BeyondEvil deleted the remove-unused-markers branch August 5, 2019 16:34
@ssbarnea ssbarnea added the bug This issue/PR relates to a bug. label Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants