Respect pytest --capture=no and -s flags #353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeyondEvil
approved these changes
Oct 21, 2020
|
Yes, you’re absolutely correct! I missed that the for-loop belonged to the outer if.
…On 21 Oct 2020, 15:15 +0200, Gleb Nikonorov ***@***.***>, wrote:
@gnikonorov commented on this pull request.
In pytest_html/plugin.py:
> - if report.longrepr:
- # longreprtext is only filled out on failure by pytest
- # otherwise will be None.
- # Use full_text if longreprtext is None-ish
- # we added full_text elsewhere in this file.
- text = report.longreprtext or report.full_text
- for line in text.splitlines():
- separator = line.startswith("_ " * 10)
- if separator:
- log.append(line[:80])
- else:
- exception = line.startswith("E ")
- if exception:
- log.append(html.span(raw(escape(line)), class_="error"))
+
+ if pytest_capture_value != "no":
I don't think we could do that, since this if also contains the for section in report.sections: block. We'd have to duplicate the statement then which is confusing IMO
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Bump for a review/merge @ssbarnea |
|
Hey @BeyondEvil if you are OK with this PR can you merge it in ( I'd rather not merge my own PRs, since I don't know how everyone else feels about them ). I'd like this in master so I can start work on the second half of #171, implementing support for |
ssbarnea
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
pytest-htmlrespect the--capture=noand-spytest flags as requested in #171.Note that this only partially resolves the issue. We should also respect
--show-capture=no, but I will add that in a follow up pr to make the changes smaller.