Add a package.json file for a better javascript development experience #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnikonorov
added
skip-changelog
ssbarnea
reviewed
Nov 7, 2020
|
@ssbarnea I ended up removing all data from the |
|
Bump @ssbarnea or @BeyondEvil |
gnikonorov
commented
Nov 10, 2020
| "grunt-contrib-qunit": "^4.0.0", | ||
| "phantomjs-prebuilt": "2.1.15" | ||
| }, | ||
| "devDependencies": {}, |
There was a problem hiding this comment.
Note that I intentionally left this in. I'd rather be explicit in listing that there are no dev dependencies than have people guessing.
BeyondEvil
approved these changes
Nov 10, 2020
Comment on lines
+78
to
+87
| 1. Update your local master with the upstream master (``git pull --rebase upstream master``) | ||
| 2. Create a new branch | ||
| 3. Update ``CHANGES.rst`` with the new version, today's date, and all changes/new features | ||
| 4. Update the ``version`` field in ``package.json`` with the new version | ||
| 5. Commit and push the new branch and then create a new pull request | ||
| 6. Wait for tests and reviews and then merge the branch | ||
| 7. Once merged, update your local master again (``git pull --rebase upstream master``) | ||
| 8. Tag the release with the new release version (``git tag v<new tag>``) | ||
| 9. Push the tag (``git push upstream --tags``) | ||
| 10. Done. Check `CI <https://github.com/pytest-dev/pytest-html/actions>`_ for release progress. |
There was a problem hiding this comment.
Here's a trick: You can change all the numbers to 1, and RST will renumber them. That way, if you have to insert something, it will only be a one-line change. :)
ssbarnea
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
package.jsonfile to simplify the experience of developing the JS portion of this plugin.This also better sets us up to tackle #350 since we won't have to remember all the JS dependencies anymore, and can use more modern practices for JS development.