Skip to content

fix: Only run npm when building from source #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2023
Merged

fix: Only run npm when building from source #758

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions scripts/npm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,15 @@
import subprocess
from pathlib import Path

from hatchling.builders.hooks.plugin.interface import BuildHookInterface


class NpmBuildHook(BuildHookInterface):
def initialize(self, version, build_data):
subprocess.check_output("npm ci", shell=True)
subprocess.check_output("npm run build", shell=True)
is_source = Path(self.root, ".git").exists()
app_js_exists = Path(
self.root, "src", "pytest_html", "resources", "app.js"
).exists()
if is_source or not app_js_exists:
subprocess.run("npm ci", capture_output=True, check=True, shell=True)
subprocess.run("npm run build", capture_output=True, check=True, shell=True)