Skip to content

Conversation

Kilo59
Copy link
Contributor

@Kilo59 Kilo59 commented Mar 13, 2024

@@ -13,6 +14,7 @@
__all__ = [
"MockerFixture",
"MockFixture",
"MockType",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also AsyncMockType?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

I'm not a maintainer to pytest-mock but it just so happened that I thought to check github issues for this & you had made an awesome change that solved issue.

Thank you!

@nicoddemus
Copy link
Member

Sorry @Kilo59 I've missed the notification for this PR, I will take a look in a few days. 👍

@nicoddemus
Copy link
Member

Actually found some time to review it and is pretty simple. Thanks!

@nicoddemus nicoddemus merged commit 366966b into pytest-dev:main Mar 21, 2024
@Kilo59 Kilo59 deleted the patch-1 branch March 22, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for easier import of mocker.Mock | mocker.MagicMock types
3 participants