Skip to content

init reactor greenlet earlier #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 11, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions pytest_twisted.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,7 @@ def inlineCallbacks(fun, *args, **kw):


def pytest_namespace():
return dict(
inlineCallbacks=inlineCallbacks,
blockon=blockon,
init_twisted_greenlet=init_twisted_greenlet
)
return dict(inlineCallbacks=inlineCallbacks, blockon=blockon)


def init_twisted_greenlet():
Expand All @@ -54,10 +50,14 @@ def stop_twisted_greenlet():
gr_twisted.switch()


def pytest_addhooks(pluginmanager):
init_twisted_greenlet()


@pytest.fixture(scope="session", autouse=True)
def twisted_greenlet(request):
request.addfinalizer(stop_twisted_greenlet)
return init_twisted_greenlet()
return gr_twisted


def _pytest_pyfunc_call(pyfuncitem):
Expand Down
137 changes: 80 additions & 57 deletions testing/test_basic.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,77 +5,77 @@

def test_fail_later(testdir):
testdir.makepyfile("""
from twisted.internet import reactor, defer

def test_fail():
def doit():
try:
1 / 0
except:
d.errback()

d = defer.Deferred()
reactor.callLater(0.01, doit)
return d
""")
from twisted.internet import reactor, defer
def test_fail():
def doit():
try:
1 / 0
except:
d.errback()
d = defer.Deferred()
reactor.callLater(0.01, doit)
return d
""")
rr = testdir.run(sys.executable, "-m", "pytest")
outcomes = rr.parseoutcomes()
assert outcomes.get("failed") == 1


def test_succeed_later(testdir):
testdir.makepyfile("""
from twisted.internet import reactor, defer

def test_succeed():
d = defer.Deferred()
reactor.callLater(0.01, d.callback, 1)
return d
""")
from twisted.internet import reactor, defer
def test_succeed():
d = defer.Deferred()
reactor.callLater(0.01, d.callback, 1)
return d
""")
rr = testdir.run(sys.executable, "-m", "pytest")
outcomes = rr.parseoutcomes()
assert outcomes.get("passed") == 1


def test_non_deferred(testdir):
testdir.makepyfile("""
from twisted.internet import reactor, defer

def test_succeed():
return 42
""")
from twisted.internet import reactor, defer
def test_succeed():
return 42
""")
rr = testdir.run(sys.executable, "-m", "pytest")
outcomes = rr.parseoutcomes()
assert outcomes.get("passed") == 1


def test_exception(testdir):
testdir.makepyfile("""
def test_more_fail():
raise RuntimeError("foo")
""")
def test_more_fail():
raise RuntimeError("foo")
""")
rr = testdir.run(sys.executable, "-m", "pytest")
outcomes = rr.parseoutcomes()
assert outcomes.get("failed") == 1


def test_inlineCallbacks(testdir):
testdir.makepyfile("""
from twisted.internet import reactor, defer
import pytest

@pytest.fixture(scope="module",
params=["fs", "imap", "web"])
def foo(request):
return request.param


@pytest.inlineCallbacks
def test_succeed(foo):
yield defer.succeed(foo)
if foo == "web":
raise RuntimeError("baz")
""")
from twisted.internet import reactor, defer
import pytest
@pytest.fixture(scope="module",
params=["fs", "imap", "web"])
def foo(request):
return request.param
@pytest.inlineCallbacks
def test_succeed(foo):
yield defer.succeed(foo)
if foo == "web":
raise RuntimeError("baz")
""")
rr = testdir.run(sys.executable, "-m", "pytest", "-v")
outcomes = rr.parseoutcomes()
assert outcomes.get("passed") == 2
Expand All @@ -84,22 +84,45 @@ def test_succeed(foo):

def test_twisted_greenlet(testdir):
testdir.makepyfile("""
import pytest, greenlet

MAIN = None


@pytest.fixture(scope="session", autouse=True)
def set_MAIN(request, twisted_greenlet):
global MAIN
MAIN = twisted_greenlet

import pytest, greenlet

MAIN = None


@pytest.fixture(scope="session", autouse=True)
def set_MAIN(request, twisted_greenlet):
global MAIN
MAIN = twisted_greenlet


def test_MAIN():
assert MAIN is not None
assert MAIN is greenlet.getcurrent()

""")
rr = testdir.run(sys.executable, "-m", "pytest", "-v")
outcomes = rr.parseoutcomes()
assert outcomes.get("passed") == 1

def test_MAIN():
assert MAIN is not None
assert MAIN is greenlet.getcurrent()

""")
def test_blocon_in_hook(testdir):
testdir.makeconftest("""
import pytest
from twisted.internet import reactor, defer

def pytest_configure(config):
d = defer.Deferred()
reactor.callLater(0.01, d.callback, 1)
pytest.blockon(d)
""")
testdir.makepyfile("""
from twisted.internet import reactor, defer

def test_succeed():
d = defer.Deferred()
reactor.callLater(0.01, d.callback, 1)
return d
""")
rr = testdir.run(sys.executable, "-m", "pytest", "-v")
outcomes = rr.parseoutcomes()
assert outcomes.get("passed") == 1