Mark test as complete at teardown. #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please add an accompanying test |
file. - Add `test_crashing_item_teardown` to validate crash behavior at teardown.
|
Hi Ronny! I added a test and improved another one ;) |
|
Thanks a lot for this! LGTM as well. Would you mind adding a CHANGELOG entry? |
nicoddemus
approved these changes
Mar 7, 2017
|
Done! Any idea when 1.16 is going out? |
|
We can make a release as soon as this is merged I guess. @RonnyPfannschmidt could you take a look and merge this if you are OK with it? |
|
sorry for the long wait, it seems i had a situation where a bulk of notifications was marked read |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for #124.