Skip to content

Mark test as complete at teardown. #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 5, 2017
Merged

Mark test as complete at teardown. #125

merged 4 commits into from
May 5, 2017

Conversation

reginaldl
Copy link
Contributor

Possible fix for #124.

@RonnyPfannschmidt
Copy link
Member

please add an accompanying test

  file.
- Add `test_crashing_item_teardown` to validate crash behavior at
  teardown.
@reginaldl
Copy link
Contributor Author

Hi Ronny!

I added a test and improved another one ;)
Let me know if this fix needs additional work.

@nicoddemus
Copy link
Member

Thanks a lot for this!

LGTM as well. Would you mind adding a CHANGELOG entry?

@reginaldl
Copy link
Contributor Author

Done! Any idea when 1.16 is going out?

@nicoddemus
Copy link
Member

We can make a release as soon as this is merged I guess.

@RonnyPfannschmidt could you take a look and merge this if you are OK with it?

@RonnyPfannschmidt RonnyPfannschmidt merged commit e83aae6 into pytest-dev:master May 5, 2017
@RonnyPfannschmidt
Copy link
Member

sorry for the long wait, it seems i had a situation where a bulk of notifications was marked read

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants