stdout and stderr double-encoded in junitxml

[pytestbot]

Originally reported by: Jason R. Coombs (BitBucket: jaraco, GitHub: jaraco)

---

I'm finding that the junit XML generated by pytest 2.2.4 gets double-encoded output. For example, here's a snippet from one run:

<failure>... Error in parsing

gryphon/models/qsl.py:63: QSLError</failure><system-err>Message 1
{&amp;apos;exception&amp;apos;: [&amp;apos;ParseError: Both inline and named res
ponse lists were used for question lookahead\n&amp;apos;],
 &amp;apos;message&amp;apos;: [&amp;apos;ParseError: Both inline and named respo
nse lists were used for question lookahead\n&amp;apos;],
 &amp;apos;status&amp;apos;: 500,
...

The stderr stream for that looks something like:

Message 1
{'exception': ['ParseError: Both inline and named response lists were used for question lookahead\n'],
 'message': ['ParseError: Both inline and named response lists wer eused for the queston lookahead\n'],
 'status': 500,

Notice that the tickmarks are being escaped for XML (to ') and then again the ampersand is getting escaped to '.

---

• Bitbucket: https://bitbucket.org/pytest-dev/pytest/issue/178

[pytestbot]

Original comment by Jason R. Coombs (BitBucket: jaraco, GitHub: jaraco):

---

After a bit of investigation, it appears the problem is due to encoding in two places. When the content is added to the tag, in LogXML.append_failure, bin_xml_escape is called, which converts ' to '. Then, when the tag is rendered, it calls py._xmlgen.escape.

Removing the call to bin_xml_escape helps, and addresses the issues I've encountered, but almost certainly breaks whatever was intended by bin_xml_escape (specifically escaping other characters).

Note that the test in the pull request doesn't pass by removing bin_xml_escape because the apostrophes aren't escaped (probably because they don't need to be in XML text), so the test may need to be updated.

Please let me know if there's more I can do to expedite a fix for this issue.

Regards - Jason

[pytestbot]

Original comment by Ronny Pfannschmidt (BitBucket: RonnyPfannschmidt, GitHub: RonnyPfannschmidt):

---

i think i introduced that bug when fixing errors about incorrectly handling some binary data

im under the impression that returning a py.xml.raw might be needed

[pytestbot]

Original comment by Ronny Pfannschmidt (BitBucket: RonnyPfannschmidt, GitHub: RonnyPfannschmidt):

---

fix issue #178 and extend the failure escape test