Skip to content

Tests failed with python3.8.0a1 #4716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matrixise opened this issue Feb 4, 2019 · 5 comments
Closed

Tests failed with python3.8.0a1 #4716

matrixise opened this issue Feb 4, 2019 · 5 comments
Labels
topic: rewrite related to the assertion rewrite mechanism type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog

Comments

@matrixise
Copy link

Hi,

I have tried to execute the tests with the new alpha release of Python 3.8

https://www.python.org/downloads/release/python-380a1/

And I get some errors, maybe it's an issue with pytest or with pytest but I have created an issue on the bug tracker of Python (https://bugs.python.org/issue35895)

tox-pytest-38-stdout.log

@RonnyPfannschmidt
Copy link
Member

thanks for trying and getting us a early pointer about python 3.8 compatibility

At first glance it seems all to come down to minor differences in ast for the assertion rewriting which is a great starting point, it should be relatively straightforward to sort out the issues on time.

As of now i cant tell which of those are intended updates of the ast and which are python alpha issues that will go away themselves - the tracking issue here and over in the python tracker will be a great tool to stay on top of it.

👍

@RonnyPfannschmidt RonnyPfannschmidt added the type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog label Feb 4, 2019
@RonnyPfannschmidt
Copy link
Member

after taking a glance at the detail issues in the python tracker it seems that the ast provides various rock-solid extra metadata elements that will allow us to ensure MUCH more solid statement range finding,
a side effect seems to be some extra nodes we don't yet expect

@matrixise
Copy link
Author

hi @RonnyPfannschmidt no problem, I think I will create a CI for the most used libraries and Python 3.8.0aX and will create an issue for each library, maybe I will help the community with this CI.

Have a nice day.

@matrixise
Copy link
Author

@RonnyPfannschmidt cool nice news.

@RonnyPfannschmidt RonnyPfannschmidt added the topic: rewrite related to the assertion rewrite mechanism label Feb 4, 2019
@asottile
Copy link
Member

asottile commented Feb 5, 2019

Is there a stacktrace for this? I'm having trouble finding the failure mode and what triggers it -- can it be edited into the original message here and/or on the bpo issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: rewrite related to the assertion rewrite mechanism type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog
Projects
None yet
Development

No branches or pull requests

3 participants