Skip to content

Remove workaround for docstrings for py38+ #4723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2019
Merged

Remove workaround for docstrings for py38+ #4723

merged 1 commit into from
Feb 5, 2019

Conversation

asottile
Copy link
Member

@asottile asottile commented Feb 5, 2019

test-only changes for #4716

$ pytest testing/test_assertrewrite.py 
============================ test session starts ============================
platform darwin -- Python 3.8.0a1+, pytest-4.2.1.dev15+ga9457345, py-1.7.0, pluggy-0.8.1
hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase('/Users/asottile/workspace/cpython/pytest/.hypothesis/examples')
rootdir: /Users/asottile/workspace/cpython/pytest, inifile: tox.ini
plugins: hypothesis-4.5.1
collected 66 items                                                          

testing/test_assertrewrite.py ....................................... [ 59%]
....s..ssss................                                           [100%]
========================== short test summary info ==========================
SKIPPED [1] testing/test_assertrewrite.py:866: python 2 only
SKIPPED [1] testing/test_assertrewrite.py:915: condition: sys.version_info[0] >= 3
SKIPPED [1] testing/test_assertrewrite.py:924: condition: sys.version_info[0] >= 3
SKIPPED [1] testing/test_assertrewrite.py:935: condition: sys.version_info[0] >= 3
SKIPPED [1] testing/test_assertrewrite.py:946: condition: sys.version_info[0] >= 3

=================== 61 passed, 5 skipped in 6.76 seconds ====================

@codecov
Copy link

codecov bot commented Feb 5, 2019

Codecov Report

Merging #4723 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4723      +/-   ##
==========================================
+ Coverage   95.68%   95.68%   +<.01%     
==========================================
  Files         113      113              
  Lines       24970    24963       -7     
  Branches     2479     2478       -1     
==========================================
- Hits        23892    23886       -6     
  Misses        762      762              
+ Partials      316      315       -1
Flag Coverage Δ
#docs 29.67% <0%> (+0.08%) ⬆️
#doctesting 29.67% <0%> (+0.08%) ⬆️
#linting 29.67% <0%> (+0.08%) ⬆️
#linux 95.5% <100%> (ø) ⬆️
#nobyte 92.29% <100%> (ø) ⬆️
#numpy 93.1% <100%> (-0.01%) ⬇️
#pexpect 42.1% <0%> (+0.01%) ⬆️
#py27 93.69% <100%> (ø) ⬆️
#py34 91.77% <100%> (+0.06%) ⬆️
#py35 91.77% <100%> (+0.06%) ⬆️
#py36 91.79% <100%> (+0.06%) ⬆️
#py37 93.8% <100%> (+0.02%) ⬆️
#trial 93.1% <100%> (-0.01%) ⬇️
#windows 93.87% <100%> (-0.01%) ⬇️
#xdist 93.71% <100%> (-0.01%) ⬇️
Impacted Files Coverage Δ
testing/test_assertrewrite.py 83.48% <100%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a945734...3153740. Read the comment docs.

@asottile asottile merged commit c780d1f into pytest-dev:master Feb 5, 2019
@asottile asottile deleted the docstring_fix_py38 branch February 5, 2019 23:23
blueyed added a commit to blueyed/pytest that referenced this pull request Sep 25, 2020
NOTE: fixing/reverting of `doc = getattr(mod, "docstring", None)` was
missed in 3153740 (pytest-dev#4723).

It was added initially in
pytest-dev#2870, but never made it into a
final Python release.
Basically reverts / revisits based on changes introduced in 734c435.
blueyed added a commit to blueyed/pytest that referenced this pull request Sep 25, 2020
NOTE: fixing/reverting of `doc = getattr(mod, "docstring", None)` was
missed in 3153740 (pytest-dev#4723).

It was added initially in
pytest-dev#2870, but never made it into a
final Python release.  Basically reverts / revisits based on changes introduced in 734c435.

Adjusts a7dfc6f (#243).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants