Skip to content

refactor terminalwriter configuration #4733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RonnyPfannschmidt opened this issue Feb 6, 2019 · 0 comments · Fixed by #4741
Closed

refactor terminalwriter configuration #4733

RonnyPfannschmidt opened this issue Feb 6, 2019 · 0 comments · Fixed by #4741
Labels
topic: reporting related to terminal output and user-facing messages and errors type: refactoring internal improvements to the code

Comments

@RonnyPfannschmidt
Copy link
Member

as part of #4720 we discovered that the terminal-writer plugin inconsistently handles its configuration

this should be re-mediated
@RonnyPfannschmidt RonnyPfannschmidt added topic: reporting related to terminal output and user-facing messages and errors type: refactoring internal improvements to the code labels Feb 6, 2019
@nicoddemus nicoddemus mentioned this issue Feb 7, 2019
Merged
6 tasks
twmr added a commit to twmr/pytest that referenced this issue Feb 7, 2019
@twmr
Remove terminal_reporter workaroundd from logging.py
eda5c2a 
The workaround was removed form the logging module by creating python
properties for verbosity related settings in the terminalreporter.

Closes: pytest-dev#4733
@twmr twmr mentioned this issue Feb 7, 2019
Merged
6 tasks
twmr added a commit to twmr/pytest that referenced this issue Feb 7, 2019
@twmr
Remove terminal_reporter workaround from logging.py
e8560c9 
The workaround was removed from the logging module by creating python
properties for verbosity related settings in the terminalreporter.

Closes: pytest-dev#4733
twmr added a commit to twmr/pytest that referenced this issue Feb 7, 2019
@twmr
Remove terminal_reporter workaround from logging.py
ddbea29 
The workaround was removed from the logging module by creating python
properties for verbosity related settings in the terminalreporter.

Closes: pytest-dev#4733
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: reporting related to terminal output and user-facing messages and errors type: refactoring internal improvements to the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove terminal_reporter workaround from logging.py twmr/pytest
1 participant
@RonnyPfannschmidt