Skip to content

Assertion rewriting breaks jedi due to missing InspectLoader support #6643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iwanb opened this issue Jan 31, 2020 · 2 comments
Open

Assertion rewriting breaks jedi due to missing InspectLoader support #6643

iwanb opened this issue Jan 31, 2020 · 2 comments
Labels
topic: rewrite related to the assertion rewrite mechanism

Comments

@iwanb
Copy link
Contributor

iwanb commented Jan 31, 2020

platform linux -- Python 3.7.6, pytest-5.3.4, py-1.6.0, pluggy-0.12.0

I am using IPython with jedi completions within a pytest session. Assertion rewriting is enabled, but doing completions on rewritten modules crashes jedi because mod.__loader__.is_package is not implemented.
https://docs.python.org/3/library/importlib.html#importlib.abc.InspectLoader

AFAIK is would be best if the importer subclass those:
https://docs.python.org/3/library/importlib.html#importlib.abc.FileLoader
https://docs.python.org/3/library/importlib.html#importlib.abc.SourceLoader

To get all the methods implemented.

See the trace at davidhalter/jedi#1487

This is probably related to #3919 where is_package was removed.

@RonnyPfannschmidt
Copy link
Member

as by now the mainline no longer supports python 2,
i think we can investigate sorting this out by using more of importlib

thanks for bringing this up

@blueyed
Copy link
Contributor

blueyed commented Feb 1, 2020

This is probably related to #3919 where is_package was removed.

It was removed in 4cd08f9 (#5468).
Not sure if bug or enhancement though. (btw: the Jedi issue was fixed already)

@blueyed blueyed added the topic: rewrite related to the assertion rewrite mechanism label Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: rewrite related to the assertion rewrite mechanism
Projects
None yet
Development

No branches or pull requests

3 participants