-k mishandles numbers

[Sup3rGeo]

Using pytest 5.4.1.

It seems that pytest cannot handle keyword selection with numbers, like -k "1 or 2".

Considering the following tests:

def test_1():
    pass

def test_2():
    pass

def test_3():
    pass

Selecting with -k 2 works:

(venv) Victors-MacBook-Pro:keyword_number_bug fikrettiryaki$ pytest --collect-only -k 2
========================================================================================================== test session starts ===========================================================================================================
platform darwin -- Python 3.7.7, pytest-5.4.1, py-1.8.1, pluggy-0.13.1
rootdir: /Users/fikrettiryaki/PycharmProjects/keyword_number_bug
collected 3 items / 2 deselected / 1 selected                                                                                                                                                                                            
<Module test_one.py>
  <Function test_2>

But selecting with -k "1 or 2" doesn't, as I get all tests:

(venv) Victors-MacBook-Pro:keyword_number_bug fikrettiryaki$ pytest --collect-only -k "1 or 2"
========================================================================================================== test session starts ===========================================================================================================
platform darwin -- Python 3.7.7, pytest-5.4.1, py-1.8.1, pluggy-0.13.1
rootdir: /Users/fikrettiryaki/PycharmProjects/keyword_number_bug
collected 3 items                                                                                                                                                                                                                        
<Module test_one.py>
  <Function test_1>
  <Function test_2>
  <Function test_3>

If I make it a string though, using -k "_1 or _2", then it works again:

(venv) Victors-MacBook-Pro:keyword_number_bug fikrettiryaki$ pytest --collect-only -k "_1 or _2"
========================================================================================================== test session starts ===========================================================================================================
platform darwin -- Python 3.7.7, pytest-5.4.1, py-1.8.1, pluggy-0.13.1
rootdir: /Users/fikrettiryaki/PycharmProjects/keyword_number_bug
collected 3 items / 1 deselected / 2 selected                                                                                                                                                                                            
<Module test_one.py>
  <Function test_1>
  <Function test_2>

I see there are some notes about selecting based on keywords here but it was not clear if it applied to this case:
http://doc.pytest.org/en/latest/example/markers.html#using-k-expr-to-select-tests-based-on-their-name

So, is this a bug? Thanks!

[bluetech]

IMO this is a bug.

This happens before the -k expression is evaluated using eval, 1 and 2 are evaluated as numbers, and 1 or 2 is just evaluated to True which means all tests are included. On the other hand _1 is an identifier which only evaluates to True if matches the test name.

If you are interested on working on it, IMO it would be good to move away from eval in favor of parsing ourselves. See here for discussion: #6822 (comment)

[Sup3rGeo]

@bluetech indeed! Thanks for the pointer, it seems to be really the same problem as the other issue.