Skip to content

Allow users to specify version information for the required_plugins INI key #7346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gnikonorov opened this issue Jun 10, 2020 · 3 comments · Fixed by #7366
Closed

Allow users to specify version information for the required_plugins INI key #7346

gnikonorov opened this issue Jun 10, 2020 · 3 comments · Fixed by #7366
Assignees
@gnikonorov
Labels
topic: config related to config handling, argument parsing and config file type: proposal proposal for a new feature, often to gather opinions or design the API around the new feature

Comments

@gnikonorov
Copy link
Member

gnikonorov commented Jun 10, 2020 •
edited by nicoddemus
Loading

Building off of #7305, we should allow users to specify the required versions of the plugins they would like to make required. This should be implemented as defined in PEP 440, and should be optional after each plugin name in the list of required plugins.

For example:

[pytest]
required_plugins = pugin1===1.0.0 plugin2<=5.6.1 plugin3 plugin4~=3.2.1
@gnikonorov gnikonorov added type: proposal proposal for a new feature, often to gather opinions or design the API around the new feature topic: config related to config handling, argument parsing and config file labels Jun 10, 2020
@gnikonorov gnikonorov self-assigned this Jun 10, 2020
@gnikonorov gnikonorov mentioned this issue Jun 10, 2020
Merged
@gnikonorov
Copy link
Member Author

Thoughts @nicoddemus and @RonnyPfannschmidt?

@nicoddemus
Copy link
Member

Yep the description is accurate, thanks. We should use packaging to match the versions.

@gnikonorov
Copy link
Member Author

Thanks for suggesting packaging @nicoddemus, I’ll use it

@gnikonorov gnikonorov mentioned this issue Jun 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gnikonorov gnikonorov

Labels
topic: config related to config handling, argument parsing and config file type: proposal proposal for a new feature, often to gather opinions or design the API around the new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow users to provide version information to the required_plugins INI key gnikonorov/pytest
2 participants
@nicoddemus @gnikonorov