Allow users to provide version information to the required_plugins INI key #7366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnikonorov
changed the title
|
Friendly ping for a review/merge @nicoddemus and/or @bluetech |
bluetech
approved these changes
Jun 14, 2020
| @@ -0,0 +1 @@ | |||
| Version information as defined by `PEP 440 <https://www.python.org/dev/peps/pep-0440/#version-specifiers>`_ may now be included when providing plugins to the ``required_plugins`` configuration option. | |||
There was a problem hiding this comment.
Possibly we should include this in the changelog which added required_plugins, since it's the same release? (I'm OK either way)
There was a problem hiding this comment.
No strong feelings for either as well, but I think splitting would document the multiple github issues that were used for the required_plugins feature better ( since we arrange them one issue per line item ). Otherwise, we don't have easy to follow documentation for what closed the linked issue
|
Bump for a merge @RonnyPfannschmidt @bluetech @nicoddemus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7346
Add in the ability to specify versioning information for the
required_pluginsINI key