Defer removing tmpdir #10614
Open
Defer removing tmpdir #10614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this PR be reviewed? Please leave any questions if something is not clear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #10564.
In the discussion on the issue, I believe majority agreed to defer the removal of temporary directories. Therefor, this PR has been implemented that way. If there needs to be more discussions, we can do it in the thread of this PR I think.
Also, I am planning to make another PR after this based on #10546 for the following reasons.
atexitand add integration tests fortmpdirfixture #10546, we can easily revert the commit and rollback to this PR if some regression happens.CC: @The-Compiler @RonnyPfannschmidt @nicoddemus