Param ids fix #1092
Merged
Param ids fix #1092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1064,7 +1068,7 @@ def _escape_bytes(val): | |||
| is a full ascii string, otherwise escape it into its binary form. | |||
| """ | |||
| try: | |||
| return val.encode('ascii') | |||
| return val.decode('ascii') | |||
| except UnicodeDecodeError: | |||
| return val.encode('string-escape') | |||
There was a problem hiding this comment.
im not 100% sure off-hand is string-escape correctly used that way?
There was a problem hiding this comment.
It seems so:
Python 2.7.10 (default, May 23 2015, 09:40:32) [MSC v.1500 32 bit (Intel)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> u'ação'
u'a\xe7\xe3o'
>>> u'ação'.encode('utf-8')
'a\xc3\xa7\xc3\xa3o'
>>> s=_
>>> s.encode('string-escape')
'a\\xc3\\xa7\\xc3\\xa3o'
This was referenced Sep 30, 2015
| return encoded_bytes.decode('ascii') | ||
| if val: | ||
| # source: http://goo.gl/bGsnwC | ||
| import codecs |
There was a problem hiding this comment.
i guess it makes sense to move "import codecs" outside the function (within the py3 if section)
|
Anything else guys? |
|
FML, now it has conflicts, |
|
Fixed merge conflict. 😅 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1087
Fix #1085