Fix autouse fixtures and doctest modules #1102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main problem was that previously DoctestModule was setting up its fixtures during collection, instead of letting each DoctestItem make its own fixture setup Fix pytest-dev#1100 Fix pytest-dev#1057
nicoddemus
force-pushed
the
doctest-fixtures-fix
branch
from
8e5536e to
a14c77a
Compare
nicoddemus
changed the title
|
from my pov this one is fine, but i'm not sure f it should be in master or in feature |
|
I think on |
|
Any chance of merging this for |
|
I asked in IRC if someone wanted to review it yesterday and how important it was for 2.8.2, and nobody replied 😉 I can re-package (and to some degree test) 2.8.2 with it in tomorrow if it's in then, but I don't think I can review it properly, sorry. |
|
No worries @The-Compiler! 😄 |
|
This didn't make it into 2.8.2, sorry - let's just do a 2.8.3 soon-ish instead of further delaying it 😉 |
RonnyPfannschmidt
added a commit
that referenced
this pull request
Oct 10, 2015
Fix autouse fixtures and doctest modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that
DoctestModulewas setting up fixtures before forwarding agetfixturefunction to the doc-tests; the correct approach is to actually let eachDoctestItemconfigure its own fixtures during itssetupphase.Took the opportunity to add a lot of tests with all possible scopes to ensure all of them work properly.
Fix #1100
Fix #1057
Probably also fixes #943