Skip to content

Catch OSError from getpass.getuser() #11875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 29, 2024
Merged

Catch OSError from getpass.getuser() #11875

merged 2 commits into from
Jan 29, 2024

Conversation

rmartin16
Copy link
Contributor

@rmartin16 rmartin16 commented Jan 28, 2024 •
edited
Loading

@rmartin16
Catch OSError from getpass.getuser()
e5584da 
- Previously, `getpass.getuser()` would leak an ImportError if the
  USERNAME environment variable was not set on Windows because the `pwd`
  module cannot be imported.
- Starting in Python 3.13.0a3, it only raises `OSError`.
@rmartin16 rmartin16 marked this pull request as ready for review January 28, 2024 23:05
nicoddemus
nicoddemus approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicoddemus nicoddemus merged commit 14d3707 into pytest-dev:main Jan 29, 2024
@github-actions github-actions bot mentioned this pull request Jan 29, 2024
Merged
@rmartin16 rmartin16 deleted the win-no-username-3.13-fix branch January 29, 2024 02:07
mahmoud added a commit to mahmoud/face that referenced this pull request Nov 4, 2024
@mahmoud
drop py37 because pytest <8.0.x breaks on windows with python 3.13 (p…
f0f9c2e 
…ytest-dev/pytest#11875)
@rly rly mentioned this pull request Nov 22, 2024
Merged
6 tasks
@freakboy3742 freakboy3742 mentioned this pull request Jul 29, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using Python 3.13.0a3+ on Windows when USERNAME env var is masked/unset, get_user() leaks OSError and breaks (at least) tmp_path usage
2 participants
@rmartin16 @nicoddemus