Fixed stdout/stderr capture when using pdb #1315
Conversation
|
Thanks for the PR @foxx! This looks good, but it is missing at least one test for that. There are several from test_pdb.py that you can base a test on. Also, please add a note to the |
|
Doh sorry I got lazy, updating PR now |
| assert False | ||
| """) | ||
| child = testdir.spawn_pytest("--pdb %s" % p1) | ||
| child.expect("(Pdb)") |
There was a problem hiding this comment.
Would it make sense to add a child.expect("getrekt") before this line? This would ascertain that the output actually got displayed before entering pdb.
There was a problem hiding this comment.
Oh actually, the output is displayed after PDB, so this is definitely a bug. Let me see if I can fix.
There was a problem hiding this comment.
Bah ignore last comment, I was wrong, it's outputting before PDB. Pushing patch now
|
Thanks @foxx! I also added a new CHANGELOG entry for the fix. 😄 |
|
No worries, sorry it took so long! |
Fixes #1223