Skip to content

Conversation

jakkdl
Copy link
Member

@jakkdl jakkdl commented Feb 4, 2025

In #11671 (comment) I hit a funky interaction where py39-pluggy started failing because the subprocess started triggering gc.

The patch is from #11671 (comment) after graingert noticed the faulty assumption that with _disable_gc would have any effect in a subprocess.

The CI only appears to fail in #11671, presumably because of pytest itself getting slightly bigger and triggering a gc, or something.

@jakkdl jakkdl requested a review from graingert February 4, 2025 11:22
@jakkdl jakkdl added the skip news used on prs to opt out of the changelog requirement label Feb 4, 2025
Copy link
Member

@graingert graingert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry I was totally going to get around to doing this

@jakkdl jakkdl merged commit 6530f42 into pytest-dev:main Feb 4, 2025
28 checks passed
@jakkdl jakkdl deleted the pluggy_gc branch February 4, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news used on prs to opt out of the changelog requirement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants