Fix decimal.FloatOperation error in pytest.approx Decimal __repr__ #13542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonnyPfannschmidt
requested changes
Jun 18, 2025
|
|
||
|
|
||
| def test_decimal_approx_repr_issue(): | ||
| trap = decimal.getcontext().traps[decimal.FloatOperation] |
There was a problem hiding this comment.
use momkeypatch.setitem to ensure undo happens even on failures (not that i expect a failure)
| @@ -530,6 +530,17 @@ class ApproxDecimal(ApproxScalar): | |||
| DEFAULT_ABSOLUTE_TOLERANCE = Decimal("1e-12") | |||
| DEFAULT_RELATIVE_TOLERANCE = Decimal("1e-6") | |||
|
|
|||
| def __repr__(self): | |||
| rel = Decimal(str(self.rel)) if isinstance(self.rel, float) else self.rel | |||
There was a problem hiding this comment.
we need to verify if using Decimal.from_float is more correct here
There was a problem hiding this comment.
also we might need to generally ensure that rel is not a float
nicoddemus
requested changes
Jun 18, 2025
| @@ -530,6 +530,17 @@ class ApproxDecimal(ApproxScalar): | |||
| DEFAULT_ABSOLUTE_TOLERANCE = Decimal("1e-12") | |||
| DEFAULT_RELATIVE_TOLERANCE = Decimal("1e-6") | |||
|
|
|||
| def __repr__(self): | |||
There was a problem hiding this comment.
Suggested change
| def __repr__(self): | |
| def __repr__(self) -> str: |
Co-authored-by: Bruno Oliveira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13530
Summary
This PR addresses a decimal.FloatOperation error that happens when calling repr() on a pytest.approx object created with a decimal.Decimal value. The error arises from comparing and formatting Decimal and float values without proper conversion, which activates the FloatOperation trap.
Changes
I modified the repr method to carefully handle Decimal and float attributes. This is done by explicitly converting float values to Decimal before comparisons and formatting.
I added checks for None to prevent invalid comparisons.
I avoided direct comparisons between float and Decimal that can lead to FloatOperation exceptions.
Testing
I created a minimal test to reproduce the FloatOperation error from pytest.approx(Decimal)'s repr().
The test passes after applying this fix, confirming that the issue is resolved.