junit: allow multiple properties with same name #1423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It might happen that test can be affected by two or more bugs. I need to be able to track them all.
|
looks good to merge, is there a special reason why both, properties and the insert-order is needed? i wonder if the changes section might be a better place in the changelog |
|
LGTM, but I'm not familiar with that part of the code and JUnit - so I'll leave this one to @RonnyPfannschmidt, @nicoddemus or anyone else who feels inclined 😉 @dajose - could you give this a look as well? (Heh, I just managed to mention @lukas-bednar as well, then noticed you're the author. Sorry, it's Monday! 😆) |
| @@ -98,7 +98,8 @@ | |||
| (auto/long/short/line/native/no), with `auto` being the default since v2.6. | |||
| Thanks `@hackebrot`_ for the PR. | |||
|
|
|||
| * | |||
| * Fix (`#1422`): junit record_xml_property doesn't allow multiple records | |||
There was a problem hiding this comment.
ops, will append underscore
lukas-bednar
force-pushed
the
junit_properties
branch
from
6921129 to
7e758a9
Compare
|
LGTM as well! 😄 Once it passes on CI we can merge it. |
nicoddemus
added a commit
that referenced
this pull request
Feb 29, 2016
junit: allow multiple properties with same name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might happen that test can be affected by two or more bugs.
I need to be able to track them all.
Fix #1422