pytest warnings summary displayed by default #1704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…funcargvalue issue1625, rename getfuncargvalue to getfixturevalue
…lapse_false Fixes pytest-dev#1503 no longer collapse false explanations
Combining multiple imports the "import pdb" imports the pytest module as opposed to the python debugger.
* added ``--disable-pytest-warnings` flag to let users disable the warnings summary. * extended/changed unit tests for the changes in the pytest core.
|
thanks for pushing this, as it stands you might want to rebase on top of the features branch after the next merge-master branch gets merged |
|
Thanks @aostr! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally got to a place with a stable internet connection. :)
I implemented the comments from @nicoddemus
If I should go another way with a PR, please let know. I think it could be easier to implement my changes on the feature branch and do another pull request. However, it this PR is merged, it should all work out of the box.
Here's a quick checklist that should be present in PRs:
featuresAUTHORSCHANGELOG(choose any open position to avoid merge conflicts with other PRs)