Documentation update for rootdir discovery #1819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note: Whenever |
| @@ -38,7 +38,8 @@ | |||
|
|
|||
| * Refined logic for determining the ``rootdir``, considering only valid | |||
| paths which fixes a number of issues: `#1594`_, `#1435`_ and `#1471`_. | |||
| Thanks to `@blueyed`_ and `@davehunt`_ for the PR. | |||
| Updated the documentation according to current behavior. Thanks to | |||
| `@blueyed`_, `@davehunt`_ and `@matthiasha`_ for the PR. | |||
There was a problem hiding this comment.
You'll need to add a link for yourself further down
|
By the way, let's hold on merging this until the release... as it is a docs update, it won't be a problem because it will immediately appear on docs.pytest.org once merged. 😁 |
|
Thanks @matthiasha, I will merge this later! 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers issue #1435: if
argsis not explicitly given, custom pytest commandline arguments are misleading pytest's rootdir discovery, if they point to an existing file/folder.Target:
master(as an addition to PR #1621 )