New-style classes implemented for python 2.7 - #2147 #2260
Merged
+351
−349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a ton @MichalTHEDUDE, you are the dude! 👍 LGTM, we should merge as soon as CI passes. |
nicoddemus
approved these changes
Feb 16, 2017
|
@nicoddemus wait, this changed pluggy? |
|
Ouch right, my bad! I will fix this in a PR. |
|
@nicoddemus it was also merged in pluggy, perhaps we can do a full update |
|
But we didn't make a new pluggy release yet, right? |
nicoddemus
added a commit
to nicoddemus/pytest
that referenced
this pull request
Feb 18, 2017
|
Regardless, fixed in #2263. 😅 |
flub
added a commit
that referenced
this pull request
Feb 19, 2017
Revert subclassing explicitly from object introduced by accident in #2260
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
(object)inheritance for all classes as per #2147.All tests are green.
All feedback appreciated :).