Skip to content

[wip] reintroduce Warnings on customclass usage #2696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

RonnyPfannschmidt
Copy link
Member

while resolving i found that we do have quite a mess in there because we register a node as a plugin, which in turn gets parsed for factories

i opted into ignoring plain nodes for factory parsing for now,
but that solution is incomplete

however it seems strictly impossible to implement this bit cleanly without breaking the world,
as introducing a session interaction plugin implementing the needed api

@nicoddemus nicoddemus changed the base branch from master to features August 16, 2017 20:23
@nicoddemus
Copy link
Member

nicoddemus commented Aug 16, 2017

Changed the target branch to features. 😉

Not sure what this entails right now, I will have to take a look at the collection code more carefully to understand what's going on.

CI failed as expected because we turned warnings into errors to avoid breaking test suites that do the same. 😁

@nicoddemus
Copy link
Member

@RonnyPfannschmidt gentle ping. 👍

@RonnyPfannschmidt
Copy link
Member Author

@nicoddemus this one is on hiatus, i will resolveit hopefully soon

@RonnyPfannschmidt
Copy link
Member Author

closing this one as the rebase failed and made more mess than worth it

@RonnyPfannschmidt RonnyPfannschmidt deleted the warn-customclass branch January 26, 2018 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants