Skip to content

Use correct spelling for "more-itertools" #3364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2018

Conversation

sscherfke
Copy link
Contributor

Correct the requirement more_itertools to more-itertools. Pip does not differentiate between - and _ but Conda does.

Copy link

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just spotted this too - this saved me opening a PR :-)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 92.84% when pulling 9aa2a83 on sscherfke:more-itertools into 9326759 on pytest-dev:master.

@RonnyPfannschmidt RonnyPfannschmidt merged commit ad0b433 into pytest-dev:master Apr 3, 2018
@RonnyPfannschmidt
Copy link
Member

strictly speaking this is a conda bug, but I'm more than happy to elevate it for users

thanks for sorting it out

@RonnyPfannschmidt
Copy link
Member

also whops, my mistake, we should add a trivial changelog file - do you want to, or should we?

@sscherfke
Copy link
Contributor Author

This is only a minor issue and I don’t need any credit for it and I wouldn’t even add a changelog entry for that. ;-)

@sscherfke
Copy link
Contributor Author

Thx for merging it so quickly :)

@nicoddemus
Copy link
Member

Thanks @sscherfke, I used the correct spelling when updating the conda-forge recipe and didn't even noticed it was wrong in setup.py:

https://github.com/conda-forge/pytest-feedstock/blob/7087d413e4283673385a44275b9cc6a247d60a4f/recipe/meta.yaml#L30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants