Skip to content

[wip] detangle Config init #3376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

RonnyPfannschmidt
Copy link
Member

currently config initialization is bound to the namespace hooks nad technically broken since years

the fix requires removing the pytest_namespace hook

@RonnyPfannschmidt RonnyPfannschmidt changed the base branch from master to features April 7, 2018 20:50
@coveralls
Copy link

coveralls commented Apr 7, 2018

Coverage Status

Coverage increased (+0.1%) to 92.959% when pulling 73e52b1 on RonnyPfannschmidt:config-init into 2962c73 on pytest-dev:features.

@nicoddemus
Copy link
Member

@RonnyPfannschmidt unfortunately it is hard/impossible for me to review this because you split the config.py module and made some changes at the same time so I can't differentiate between what was moved and what was changed. 😞

@RonnyPfannschmidt
Copy link
Member Author

@nicoddemus i see, i will separate them this week then

@nicoddemus
Copy link
Member

Thanks!

@RonnyPfannschmidt
Copy link
Member Author

closing this one will restart fresh bit by bit

@RonnyPfannschmidt RonnyPfannschmidt deleted the config-init branch June 15, 2018 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants