-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix #3631 - don't store legacy markinfo when its impossible #3637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5f12531
to
4c10a75
Compare
@nicoddemus perhaps a candidate to rebase onto master? |
4c10a75
to
934ca13
Compare
You mean cherry-pick this commit into master? Why not targeting |
i simply first based it on features and by rebase i mean rebase form features onto master |
You want to rebase features onto master, but merge this branch in features still? Or you intend to merge this into master? I think this is a bug fix and can go directly to |
rebase onto master = take away from features and put onto master will do |
934ca13
to
5bd5b8c
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
.