Small refactorings #3708
Merged
Small refactorings #3708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it were before, it was keeping a reference to fixturefunc and it alive when an error occurred
pytest_fixture_setup was somewhat convoluted because it was trying to do too many things.
Since fixture and yield_fixture are identical, they should call the same code; as it was, the code inside them was already starting to deviate.
asottile
approved these changes
Jul 23, 2018
RonnyPfannschmidt
approved these changes
Jul 23, 2018
|
great job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because it seems #3705 will take longer than I would like, as commented in #3705 (review) here are some commits with small refactorings so we can get this in.