Use more flexible language_version: python3
#3839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
approved these changes
Aug 20, 2018
| @@ -5,13 +5,13 @@ repos: | |||
| hooks: | |||
| - id: black | |||
| args: [--safe, --quiet] | |||
| language_version: python3.6 | |||
| language_version: python3 | |||
There was a problem hiding this comment.
question - if https://github.com/miki725/black/blob/f3e287a29ae6b209ab489ed66dac42f03137df7b/.pre-commit-hooks.yaml declares a language versions, why do we do the same?
There was a problem hiding this comment.
they haven't tagged a release with the changed value
There was a problem hiding this comment.
i see, then lets have a followup issue to sort out once they do ^^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More and more are hitting this now that brew moved to python3.7. Here's a few reports:
Note that this is what upstream
blackdoes in their configuration: psf/black#430