Skip to content

Improve pre-commit detection for changelog filenames #3957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2018
Merged

Improve pre-commit detection for changelog filenames #3957

merged 1 commit into from
Sep 8, 2018

Conversation

asottile
Copy link
Member

@asottile asottile commented Sep 7, 2018

Resolves #3955

Before:

$ pre-commit  run changelogs-rst --all-files
changelog filenames......................................................Failed
hookid: changelogs-rst

changelog files must be named ####.(feature|bugfix|doc|removal|vendor|trivial).rst

changelog/3251.feture.rst

language: script
files: 'changelog/.*(?<!\.rst)$'
name: changelog filenames
language: fail
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note here that language: fail is a new pre-commit "language"

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 93.902% when pulling 826adaf on asottile:changelog_files into 3dd2933 on pytest-dev:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 93.902% when pulling 826adaf on asottile:changelog_files into 3dd2933 on pytest-dev:master.

@codecov
Copy link

codecov bot commented Sep 7, 2018

Codecov Report

Merging #3957 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3957      +/-   ##
==========================================
+ Coverage   94.48%   94.52%   +0.04%     
==========================================
  Files         107      107              
  Lines       23651    23651              
  Branches     2349     2349              
==========================================
+ Hits        22347    22357      +10     
+ Misses        993      987       -6     
+ Partials      311      307       -4
Flag Coverage Δ
#doctesting 28.53% <ø> (+0.06%) ⬆️
#linux 94.4% <ø> (+0.04%) ⬆️
#nobyte 0% <ø> (ø) ⬆️
#numpy 28.21% <ø> (+0.06%) ⬆️
#pexpect 0% <ø> (ø) ⬆️
#pluggymaster 93.63% <ø> (+0.03%) ⬆️
#py27 92.63% <ø> (+0.04%) ⬆️
#py34 92.18% <ø> (+0.03%) ⬆️
#py35 92.19% <ø> (+0.03%) ⬆️
#py36 92.76% <ø> (+0.04%) ⬆️
#py37 92.39% <ø> (+0.03%) ⬆️
#trial 31.29% <ø> (+0.06%) ⬆️
#windows 93.82% <ø> (ø) ⬆️
#xdist 18.48% <ø> (+0.02%) ⬆️
Impacted Files Coverage Δ
src/_pytest/terminal.py 91.6% <0%> (+1.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dd2933...826adaf. Read the comment docs.

@asottile asottile merged commit 2c90b3d into pytest-dev:master Sep 8, 2018
@asottile asottile deleted the changelog_files branch September 8, 2018 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extraneous changelog file: changelog/3251.feture.rst
3 participants