Skip to content

Document that item parameter of pytest_warning_captured hook is deprecated #4037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nicoddemus
Copy link
Member

Our policy is to not deprecate features during bugfix releases, but in this
case I believe it makes sense as we are only documenting it as deprecated,
without issuing warnings which might potentially break test suites.

This will get the word out that hook implementations should not use this parameter
at all.

Fix #4036

…cated

Our policy is to not deprecate features during bugfix releases, but in this
case I believe it makes sense as we are only documenting it as deprecated,
without issuing warnings which might potentially break test suites.

This will get the word out that hook implementers should not use this parameter
at all.

Fix pytest-dev#4036
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 93.811% when pulling 1636522 on nicoddemus:deprecate-item-warnings-captured-hook into b1fbb2a on pytest-dev:master.

@codecov
Copy link

codecov bot commented Sep 25, 2018

Codecov Report

Merging #4037 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4037      +/-   ##
=========================================
+ Coverage   94.45%   94.5%   +0.04%     
=========================================
  Files         109     109              
  Lines       23788   23788              
  Branches     2357    2357              
=========================================
+ Hits        22470   22480      +10     
+ Misses       1006    1000       -6     
+ Partials      312     308       -4
Flag Coverage Δ
#doctesting 29.36% <ø> (+0.06%) ⬆️
#linux 94.35% <ø> (+0.04%) ⬆️
#nobyte 0% <ø> (ø) ⬆️
#numpy 28.27% <ø> (+0.06%) ⬆️
#pexpect 0% <ø> (ø) ⬆️
#py27 92.62% <ø> (+0.04%) ⬆️
#py34 92.11% <ø> (+0.03%) ⬆️
#py35 92.12% <ø> (+0.03%) ⬆️
#py36 92.69% <ø> (+0.04%) ⬆️
#py37 92.32% <ø> (+0.03%) ⬆️
#trial 31.3% <ø> (+0.06%) ⬆️
#windows 93.8% <ø> (ø) ⬆️
#xdist 18.57% <ø> (+0.02%) ⬆️
Impacted Files Coverage Δ
src/_pytest/hookspec.py 100% <ø> (ø) ⬆️
src/_pytest/terminal.py 91.6% <0%> (+1.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1fbb2a...1636522. Read the comment docs.

@RonnyPfannschmidt RonnyPfannschmidt merged commit 3c23b5b into pytest-dev:master Sep 27, 2018
@nicoddemus nicoddemus deleted the deprecate-item-warnings-captured-hook branch September 27, 2018 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate item parameter of pytest_warning_captured hook
4 participants