Document that item parameter of pytest_warning_captured hook is deprecated #4037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cated Our policy is to not deprecate features during bugfix releases, but in this case I believe it makes sense as we are only documenting it as deprecated, without issuing warnings which might potentially break test suites. This will get the word out that hook implementers should not use this parameter at all. Fix pytest-dev#4036
Codecov Report
@@ Coverage Diff @@
## master #4037 +/- ##
=========================================
+ Coverage 94.45% 94.5% +0.04%
=========================================
Files 109 109
Lines 23788 23788
Branches 2357 2357
=========================================
+ Hits 22470 22480 +10
+ Misses 1006 1000 -6
+ Partials 312 308 -4
Continue to review full report at Codecov.
|
auvipy
approved these changes
Sep 26, 2018
RonnyPfannschmidt
approved these changes
Sep 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our policy is to not deprecate features during bugfix releases, but in this
case I believe it makes sense as we are only documenting it as deprecated,
without issuing warnings which might potentially break test suites.
This will get the word out that hook implementations should not use this parameter
at all.
Fix #4036