Fix trailing whitespace in FixtureDef.__repr__ #4105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## features #4105 +/- ##
============================================
- Coverage 94.52% 94.41% -0.11%
============================================
Files 109 109
Lines 23940 23940
Branches 2363 2363
============================================
- Hits 22629 22604 -25
- Misses 1001 1022 +21
- Partials 310 314 +4
Continue to review full report at Codecov.
|
nicoddemus
approved these changes
Oct 10, 2018
blueyed
commented
Oct 10, 2018
| @@ -899,7 +899,7 @@ def execute(self, request): | |||
| return hook.pytest_fixture_setup(fixturedef=self, request=request) | |||
|
|
|||
| def __repr__(self): | |||
| return "<FixtureDef name=%r scope=%r baseid=%r >" % ( | |||
| return "<FixtureDef name=%r scope=%r baseid=%r>" % ( | |||
| self.argname, | |||
| self.scope, | |||
| self.baseid, | |||
There was a problem hiding this comment.
Might also have been good to replace "name" with "argname"?
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Nov 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.