-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Spelling and grammar fixes #4264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4264 +/- ##
==========================================
- Coverage 95.87% 95.86% -0.01%
==========================================
Files 109 109
Lines 24606 24608 +2
Branches 2394 2394
==========================================
Hits 23591 23591
- Misses 720 721 +1
- Partials 295 296 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! how did you find these?
src/_pytest/pathlib.py
Outdated
@@ -106,7 +106,7 @@ def _max(iterable, default): | |||
def _force_symlink(root, target, link_to): | |||
"""helper to create the current symlink | |||
|
|||
its full of race conditions that are reasonably ok to ignore | |||
it's full of race conditions that are reasonably ok to ignore | |||
for the contex of best effort linking to the latest testrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
context ;)
Don't remember in particular, but usually it's some homegrown greps, https://github.com/client9/misspell etc |
@asottile that one looks like an nice potential addition as a pre-commit hook ^^ |
Weird, can anyone explain why codecov is saying that the coverage has decreased, when clearly that's not the case? 🤔 |
I think codecov is still buggy / having problems with the pytest repo in general. |
😞 |
Sometimes it also confuses the base commit - i.e. Travis gets run on the merge commit, but then it is compared to master or something like that. |
No description provided.