#4304 the stepwise plugin must be blocked on cacheprovider plugin block request #4307
Conversation
src/_pytest/config/__init__.py
Outdated
| @@ -476,6 +476,9 @@ def consider_preparse(self, args): | |||
| def consider_pluginarg(self, arg): | |||
| if arg.startswith("no:"): | |||
| name = arg[3:] | |||
| # PR #4304 : remove stepwise if cacheprovider is blocked | |||
| if name == "cacheprovider": | |||
| self.consider_pluginarg("no:stepwise") | |||
There was a problem hiding this comment.
please use self.set_blocked("stepwhise")
As mentionned by @RonnyPfannschmidt, use set_blocked on module stepwise (and it's brother pytest_stepwise like consider_pluginarg method does)
Codecov Report
@@ Coverage Diff @@
## master #4307 +/- ##
==========================================
+ Coverage 95.84% 95.85% +<.01%
==========================================
Files 111 111
Lines 24882 24893 +11
Branches 2426 2431 +5
==========================================
+ Hits 23848 23860 +12
+ Misses 737 736 -1
Partials 297 297
Continue to review full report at Codecov.
|
|
Thanks @fzarifian! Would you like to add yourself to |
|
Hmm perhaps we should follow the general idea taken in #4335 and instead set |
|
Hmm but I see this has the advantage of working with the standalone |
|
Thanks a lot for your help resolving the issue ;) |
|
In the end I don't think it matters much, merging. Thanks @fzarifian again! |
Thanks for submitting a PR, your contribution is really appreciated!
Here's a quick checklist that should be present in PRs (you can delete this text from the final description, this is
just a guideline):
changelogfolder, with a name like<ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.masterbranch for bug fixes, documentation updates and trivial changes.featuresbranch for new features and removals/deprecations.Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:
AUTHORSin alphabetical order;Fix #4304